Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tproxy remove cleanup controller #474

Closed
wants to merge 4 commits into from
Closed

Tproxy remove cleanup controller #474

wants to merge 4 commits into from

Conversation

kschoche
Copy link
Contributor

@kschoche kschoche commented Apr 6, 2021

Changes proposed in this PR:

  • Remove the cleanup controller and use endpoints controller to drive deregistration

How I've tested this PR:
Acceptance tests.

How I expect reviewers to test this PR:
Draft PR right now, need to add tests yet.

Checklist:

  • Tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@kschoche
fix
e59f2c6
@kschoche
# This is a combination of 5 commits.
463a11f 
# This is the 1st commit message:

fix

# This is the commit message #2:

test

# This is the commit message #3:

fix ci

# This is the commit message #4:

fix ci

# This is the commit message #5:

remove namespaces because oss agent response doesnt provide it
@kschoche
fix
af7fb65
@kschoche
remove cleanup-controller, draft
f7add22
@kschoche kschoche force-pushed the tproxy-remove-cleanup-controller branch from 76593d9 to f7add22 Compare April 6, 2021 22:43
@kschoche kschoche mentioned this pull request Apr 7, 2021
Merged
2 tasks
@kschoche
Copy link
Contributor Author

kschoche commented Apr 8, 2021

Rebased this PR off the latest feature-tproxy and raised it in here : #476

@kschoche kschoche closed this Apr 8, 2021
@thisisnotashwin thisisnotashwin deleted the tproxy-remove-cleanup-controller branch April 17, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kschoche